Refresh active playlists during song preview#1305
Open
dgruss wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a mechanism for automatically and efficiently reloading the current playlist in the song selection screen, ensuring that the playlist view stays up-to-date with underlying changes (such as file modifications), especially after a song preview ends. It also refactors playlist application logic for improved code clarity and maintainability.
Playlist Reloading and Application Enhancements:
ReloadCurrentPlaylisttoTScreenSong, which reloads and reapplies the current playlist if necessary, preserving song selection and preview state when possible, and throttling reloads to avoid excessive operations. This method is now called on each draw cycle and after music preview ends. [1] [2] [3] [4]LastPlaylistReloadTimeandPreviewEndReloaded, toTScreenSongto track reload timing and prevent redundant reloads after preview ends. These are properly initialized and reset in relevant lifecycle events. [1] [2] [3] [4] [5]PLAYLIST_RELOAD_INTERVAL_MS) to throttle automatic playlist reloads.Playlist Management Refactoring:
SetPlayListinto a new functionApplyPlayListinTPlayListManagerfor better separation of concerns and reusability.SetPlayListnow callsApplyPlayListand only proceeds if successful. [1] [2] [3]These changes collectively improve the user experience by keeping the playlist view in sync with underlying data changes, while also making the codebase more modular and maintainable.